fix(plugins): reject declared signatures when signing key is missing #1783#1987
Merged
Conversation
Require SECUSCAN_PLUGIN_SIGNATURE_KEY whenever a plugin declares a signature, even if signature enforcement is disabled globally. Co-authored-by: Cursor <cursoragent@cursor.com>
NaitikVerma6776
added
level:intermediate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signaturewere accepted whenSECUSCAN_PLUGIN_SIGNATURE_KEYwas unset and global enforcement was off._verify_plugin_integritynow always requires the signing key when a signature is present.Closes #1783
Test plan
python -m pytest testing/backend/unit/test_plugin_validator.py::TestSecurityNegativeTests::test_declared_signature_requires_key_even_when_enforcement_off -vpython -m pytest testing/backend/unit/test_plugin_integrity.py -v